netdev - Re: [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZJLwJrsEDMeJVmdJ3ykJWQJjSthYOTCPCrWOTws-Wta-Q@mail.gmail.com>
Date:	Tue, 3 Jun 2014 11:43:05 +0300
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Wei Yang <weiyang@...ux.vnet.ibm.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Amir Vadai <amirv@...lanox.com>,
	Jack Morgenstein <jackm@....mellanox.co.il>
Subject: Re: [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()

On Mon, Jun 2, 2014 at 4:53 PM, Wei Yang <weiyang@...ux.vnet.ibm.com> >

> Thanks for your notification, I saw your patch to fix this issue.
> Sorry for bringing a bug in the driver and thanks for your test :-)

sure

> Hmm... actually I don't understand how you trigger this crash?

1. load the driver with num_vfs = (say) four and probe_vf (say) = two
2. reboot

[...]

> Last but not the least, based on the fix you have submitted, the porting here
> is correct. My suggestion is after your fix is merged, you could do the
> porting to those version too.

As I wrote in the other thread to Bjorn, we're practically OOO for the
rest of this week, and anyway, I suggest we 1st see what ends up
happening with the fix to the regression introduced by your commit and
take it from there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html