netdev - Re: [RFC/PATCH v3] sh_eth: use RNC mode for packet reception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140604012656.GE25936@verge.net.au>
Date:	Wed, 4 Jun 2014 10:26:56 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:	Ben Dooks <ben.dooks@...ethink.co.uk>,
	linux-kernel@...ethink.co.uk, netdev@...r.kernel.org,
	nobuhiro.iwamatsu.yj@...esas.com, magnus.damm@...nsource.se,
	cm-hiep@...so.co.jp
Subject: Re: [RFC/PATCH v3] sh_eth: use RNC mode for packet reception

On Wed, Jun 04, 2014 at 09:29:14AM +0900, Yoshihiro Shimoda wrote:
> Hi Ben,
> 
> (2014/06/03 20:21), Ben Dooks wrote:
> > The current behaviour of the sh_eth driver is not to use the RNC bit
> > for the receive ring. This means that every packet recieved is not only
> > generating an IRQ but it also stops the receive ring DMA as well until
> > the driver re-enables it after unloading the packet.
> > 
> > This means that a number of the following errors are generated due to
> > the receive packet FIFO overflowing due to nowhere to put packets:
> > 
> > 	net eth0: Receive FIFO Overflow
> > 
> > Since feedback from Yoshihiro Shimoda shows that every supported LSI
> > for this driver should have the bit enabled it seems the best way is
> > to remove the RMCR default value from the per-system data and just
> > write it when initialising the RMCR value. This is discussed in
> > the message (http://www.spinics.net/lists/netdev/msg284912.html).
> > 
> > I have tested the RMCR_RNC configuration with NFS root filesystem and
> > the driver has not failed yet.  There are further test reports from
> > Sergei Shtylov and others for both the R8A7790 and R8A7791.
> > 
> > There is also feedback fron Cao Minh Hiep[1] which reports the
> > same issue in (http://comments.gmane.org/gmane.linux.network/316285)
> > showing this fixes issues with losing UDP datagrams under iperf.
> > 
> > Tested-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> > Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> 
> Thank you very much for the patch.
> 
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

If this patch is fine by Shimoda-san then its fine be me too.

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html