netdev - Re: [PATCH V3 0/2] Adapter not recovery from EEH error injection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140603.183853.1053149522065945120.davem@davemloft.net>
Date:	Tue, 03 Jun 2014 18:38:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	wenxiong@...ux.vnet.ibm.com
Cc:	ariel.elior@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCH V3 0/2] Adapter not recovery from EEH error injection

From: wenxiong@...ux.vnet.ibm.com
Date: Tue, 03 Jun 2014 14:14:44 -0500

> Re-submitted with space fix and new sign-off address for Milton.

Applied, thanks.

BTW, it isn't your fault, but this driver does not build very well
with BNX2X_SRIOV disabled:

  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.o
In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:27:0,
                 from drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:62:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:48: warning: ‘struct bnx2’ declared inside parameter list [enabled by default]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:48: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h: In function ‘bnx2x_vf_pci_dealloc’:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:59: warning: ‘return’ with a value, in function returning void [enabled by default]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c: In function ‘__bnx2x_remove’:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:13241:4: warning: passing argument 1 of ‘bnx2x_vf_pci_dealloc’ from incompatible pointer type [enabled by default]
In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:27:0,
                 from drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:62:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:20: note: expected ‘struct bnx2 *’ but argument is of type ‘struct bnx2x *’
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.o
In file included from drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h:27:0,
                 from drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c:29:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:48: warning: ‘struct bnx2’ declared inside parameter list [enabled by default]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:48: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h: In function ‘bnx2x_vf_pci_dealloc’:
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:574:59: warning: ‘return’ with a value, in function returning void [enabled by default]

Also, if qlogic.com is the correct email address for the driver maintainer,
the top-level MAINTAINERS file needs to be updated.