netdev - Re: [PATCH net-next v10 1/7] xen-netback: Move grant_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140604150303.GK6043@zion.uk.xensource.com>
Date:	Wed, 4 Jun 2014 16:03:03 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Wei Liu <wei.liu2@...rix.com>, <xen-devel@...ts.xen.org>,
	<netdev@...r.kernel.org>, <ian.campbell@...rix.com>,
	<david.vrabel@...rix.com>, <zoltan.kiss@...rix.com>,
	<paul.durrant@...rix.com>, <a.j.bennieston@...il.com>,
	"Andrew J. Bennieston" <andrew.bennieston@...rix.com>
Subject: Re: [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array
 back into struct xenvif.

On Wed, Jun 04, 2014 at 06:46:42PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 06/04/2014 01:30 PM, Wei Liu wrote:
> 
> >From: "Andrew J. Bennieston" <andrew.bennieston@...rix.com>
> 
> >This array was allocated separately in commit ac3d5ac2 ("xen-netback:
> >fix guest-receive-side array sizes") due to it being very large, and a
> >struct xenvif is allocated as the netdev_priv part of a struct
> >net_device, i.e. via kmalloc() but falling back to vmalloc() if the
> >initial alloc. fails.
> 
> >In preparation for the multi-queue patches, where this array becomes
> >part of struct xenvif_queue and is always allocated through vzalloc(),
> >move this back into the struct xenvif.
> 
>    Won't this cause an allocation failure and so break bisection at this patch?
> 

As stated in the commit message, this array is now allocated with
vzalloc, which is no different from what it was done before (with
vmalloc in ac3d5ac2).

Wei.

> >Signed-off-by: Andrew J. Bennieston <andrew.bennieston@...rix.com>
> >Acked-by: Wei Liu <wei.liu2@...rix.com>
> 
> WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html