netdev - Re: [PATCH net-next v10 1/7] xen-netback: Move grant_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <538F3478.8040108@cogentembedded.com>
Date:	Wed, 04 Jun 2014 19:00:08 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	David Vrabel <david.vrabel@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>, xen-devel@...ts.xen.org,
	netdev@...r.kernel.org
CC:	ian.campbell@...rix.com, zoltan.kiss@...rix.com,
	paul.durrant@...rix.com, a.j.bennieston@...il.com,
	"Andrew J. Bennieston" <andrew.bennieston@...rix.com>
Subject: Re: [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array
 back into struct xenvif.

Hello.

On 06/04/2014 06:52 PM, David Vrabel wrote:

>>> This array was allocated separately in commit ac3d5ac2 ("xen-netback:
>>> fix guest-receive-side array sizes") due to it being very large, and a
>>> struct xenvif is allocated as the netdev_priv part of a struct
>>> net_device, i.e. via kmalloc() but falling back to vmalloc() if the
>>> initial alloc. fails.

>>> In preparation for the multi-queue patches, where this array becomes
>>> part of struct xenvif_queue and is always allocated through vzalloc(),
>>> move this back into the struct xenvif.

>>     Won't this cause an allocation failure and so break bisection at this
>> patch?

> No. As Andrew already said: "...falling back to vmalloc() if the
> initial alloc. fails."

    Ah, sorry, I've managed to forget about that part. :-/

> David

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html