netdev - Re: [PATCH v3 1/6] net: fec: Factorize the .xmit transmit function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140605.151752.1006020454313961670.davem@davemloft.net>
Date:	Thu, 05 Jun 2014 15:17:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fugang.duan@...escale.com
Cc:	David.Laight@...LAB.COM, netdev@...r.kernel.org,
	shawn.guo@...aro.org, Fabio.Estevam@...escale.com,
	ezequiel.garcia@...e-electrons.com, bhutchings@...arflare.com,
	stephen@...workplumber.org, Frank.Li@...escale.com,
	eric.dumazet@...il.com
Subject: Re: [PATCH v3 1/6] net: fec: Factorize the .xmit transmit function

From: "fugang.duan@...escale.com" <fugang.duan@...escale.com>
Date: Thu, 5 Jun 2014 10:21:37 +0000

> You think the conditional has measurable performance impact on
> ethernet code paths, I agree your thinking.  But in the driver,
> there have many site/apis use the method.
> 
> So, I don't want to change it for the patch set.  It have no meaningful.
> I will submit another patch to solve all APIs with conditional for the driver.

You're adding this test, it did not exist beforehand.

For the second time I'm asking you to follow David Laight's feedback
seriously, every time he asks you to make a change your initial reaction
is to not do it, or to do it "later".  If it's for something this patch
set uniquely is doing, "later" is not an acceptable response.

I'm not applying this series until you intergrate his legitimate
feedback.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html