netdev - Re: [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140605.151929.853679355962389356.davem@davemloft.net>
Date:	Thu, 05 Jun 2014 15:19:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alexander.stein@...tec-electronic.com
Cc:	daniel.krueger@...tec-electronic.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 1/6] pch_gbe: print invalid MAC address during probe

From: Alexander Stein <alexander.stein@...tec-electronic.com>
Date: Thu,  5 Jun 2014 10:53:02 +0200

> From: Daniel Krueger <daniel.krueger@...tec-electronic.com>
> 
> It is also neat to show the actual offending MAC address instead of just
> rejecting it
> 
> Signed-off-by: Daniel Krueger <daniel.krueger@...tec-electronic.com>
> Signed-off-by: Alexander Stein <alexander.stein@...tec-electronic.com>
> ---
> 
> Changes in v2:
> * Use just a single line

I agree with other's feedback in that this code is not legitimate.

It should generate a random MAC address via the standard interfaces we
have for doing so, rather than failing to bring up the interface.

Interface bringup failure should be the absolute last resort, and we
should recover and still bring the interface up whenever we can.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html