netdev - Re: [net-next 02/14] i40e: Allow disabling of DCB via debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140605.005632.2052466271313574330.davem@davemloft.net>
Date:	Thu, 05 Jun 2014 00:56:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	neerav.parikh@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net-next 02/14] i40e: Allow disabling of DCB via debugfs

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu,  5 Jun 2014 00:49:15 -0700

> From: Neerav Parikh <neerav.parikh@...el.com>
> 
> Diagnostic and traffic generator tests fail when DCB is enabled.
> This is due to the fact that when DCB is enabled the Tx packets
> from the adapter are VLAN tagged and these tests are not expecting
> an extra tag in the packets.
> 
> So, allow disabling of the DCB flag via debugfs so that these tests
> can proceed.
> 
> New debugfs commands
> "dcb off" -- Disable DCB tagging; only works when in single TC mode
> "dcb on" -- Re-enable DCB tagging
> 
> Change-ID: I14cc894e1cbf8a3b8ecfba4a3886f9861e7678ed
> Signed-off-by: Neerav Parikh <neerav.parikh@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Please define a portable, generic, interface for this that other
drivers can make use of.

And in the future, generally speaking, please stop plopping every
diagnostic knob you come up with into debugfs by default.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html