netdev - Re: [net-next 02/14] i40e: Allow disabling of DCB via debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1401955553.19767.186.camel@jtkirshe-mobl>
Date:	Thu, 05 Jun 2014 01:05:53 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	neerav.parikh@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com
Subject: Re: [net-next 02/14] i40e: Allow disabling of DCB via debugfs

On Thu, 2014-06-05 at 00:56 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Thu,  5 Jun 2014 00:49:15 -0700
> 
> > From: Neerav Parikh <neerav.parikh@...el.com>
> > 
> > Diagnostic and traffic generator tests fail when DCB is enabled.
> > This is due to the fact that when DCB is enabled the Tx packets
> > from the adapter are VLAN tagged and these tests are not expecting
> > an extra tag in the packets.
> > 
> > So, allow disabling of the DCB flag via debugfs so that these tests
> > can proceed.
> > 
> > New debugfs commands
> > "dcb off" -- Disable DCB tagging; only works when in single TC mode
> > "dcb on" -- Re-enable DCB tagging
> > 
> > Change-ID: I14cc894e1cbf8a3b8ecfba4a3886f9861e7678ed
> > Signed-off-by: Neerav Parikh <neerav.parikh@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Please define a portable, generic, interface for this that other
> drivers can make use of.
> 
> And in the future, generally speaking, please stop plopping every
> diagnostic knob you come up with into debugfs by default.
> 
> Thank you.

Sorry about that Dave, I should have gone with my gut feeling and
dropped this patch to begin with.  I even debated over it before sending
the series out.  I am just going to drop the patch from the series since
it will take Neerav time to define the generic interface.


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)