| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1402151680-11434-1-git-send-email-per.hurtig@kau.se> Date: Sat, 7 Jun 2014 16:34:40 +0200 From: Per Hurtig <per.hurtig@....se> To: netdev@...r.kernel.org Cc: Per Hurtig <per.hurtig@....se>, eric.dumazet@...il.com, anna.brunstrom@....se, mohammad.rajiullah@....se, ncardwell@...gle.com, nanditad@...gle.com, sergei.shtylyov@...entembedded.com Subject: [PATCH] tcp: fixing TLP's FIN recovery Fix to a problem observed when losing a FIN segment that does not contain data. In such situations, TLP is unable to recover from *any* tail loss and instead adds at least PTO ms to the retransmission process, i.e., RTO = RTO + PTO. Signed-off-by: Per Hurtig <per.hurtig@....se> --- net/ipv4/tcp_output.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index d463c35..6573765 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -2130,8 +2130,10 @@ void tcp_send_loss_probe(struct sock *sk) if (WARN_ON(!skb || !tcp_skb_pcount(skb))) goto rearm_timer; - /* Probe with zero data doesn't trigger fast recovery. */ - if (skb->len > 0) + /* Probe with zero data doesn't trigger fast recovery, if FIN + * flag is not set. + */ + if ((skb->len > 0) || (TCP_SKB_CB(skb)->tcp_flags & TCPHDR_FIN)) err = __tcp_retransmit_skb(sk, skb); /* Record snd_nxt for loss detection. */ -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists