netdev - Re: [PATCH iproute2 v3] bridge: Add master device name to bridge fdb show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5394801D.6080704@mojatatu.com>
Date:	Sun, 08 Jun 2014 11:24:13 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>
CC:	davem@...emloft.net, stephen@...workplumber.org,
	netdev@...r.kernel.org, wkok@...ulusnetworks.com,
	sfeldma@...ulusnetworks.com, shm@...ulusnetworks.com,
	Vlad Yasevich <vyasevic@...hat.com>
Subject: Re: [PATCH iproute2 v3] bridge: Add master device name to bridge
 fdb show

On 06/08/14 10:44, Roopa Prabhu wrote:

> sure, you seemed to be using my below patch in your examples for fdb
> filtering.
> so thought i should resubmit. I am now ok with either.

Yes, my patch is on top of your earlier (version 1) patch. I preferred
that version.

I looked at the code a little more after sending that email.
There is some value in displaying a bridge port's unicast addresses
and even setting them; but only in the case that the bridge port is
itself an owner of an fdb. As an example of such a case when you have
another bridge attached to a bridge as a port; or when you have
something like a vxlan as a bridge port etc.
However, current code does not discriminate. I cant make sense of
why this would be intentional but possibly i am missing some use cases.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html