netdev - Re: [PATCH net-next] net: filter: cleanup A/X name usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5396B3BC.30504@redhat.com>
Date:	Tue, 10 Jun 2014 09:29:00 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Chema Gonzalez <chema@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: filter: cleanup A/X name usage

On 06/09/2014 09:25 PM, Alexei Starovoitov wrote:
...
> Point taken. Will do more thorough documentation patch to
> explain eBPF instruction set a bit better. Mainly to clarify encoding.
> eBPF tried to be as close as possible to classic BPF, since I thought
> it will make it easier to understand. That's why I reused A/X in names
> and bits in opcode encoding.
> In classic, A is accumulator and X is indeX. In eBPF I thought
> calling destination register 'a_reg' made sense, since it would
> indicate that this 'a_reg' is a register that is used as 'accumulator'
> in the instruction. Like in "bpf_add R2, 5", R2 is Accumulator.
> In "bpf_add R2, R3", R2  is Accumulator and R3 is indeX
> and BPF_X bit in opcode indicates whether 'x_reg' field of the
> instruction is used. Unfortunately that decision caused the whole
> A/X naming confusion, that this patch is addressing.
> src_reg and dst_reg are indeed better names.

I think both naming conventions (before/after) are fine, imho.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html