netdev - Re: [PATCH net-next] mrf24j40: separate h/w init and add checkings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140612.110519.583755215428272991.davem@davemloft.net>
Date:	Thu, 12 Jun 2014 11:05:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	varkabhadram@...il.com
Cc:	netdev@...r.kernel.org, alex.bluesman.smirnov@...il.com,
	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, varkab@...c.in
Subject: Re: [PATCH net-next] mrf24j40: separate h/w init and add checkings

From: David Miller <davem@...emloft.net>
Date: Thu, 12 Jun 2014 11:03:24 -0700 (PDT)

> From: Varka Bhadram <varkabhadram@...il.com>
> Date: Thu, 12 Jun 2014 14:40:48 +0530
> 
>> separate the mrf24j40 hardware initialisation from probe()
>> and adds the sanity checkings.
>> 
>> These checkings are required if somebody hasn't a right spi configuration 
>> the probe function should fail. So we have to return from there.
>> 
>> Signed-off-by: Varka Bhadram <varkab@...c.in>
> 
> Applied, thanks.

Reverted, did you even compile test this change?

drivers/net/ieee802154/mrf24j40.c: In function ‘mrf24j40_probe’:
drivers/net/ieee802154/mrf24j40.c:741:10: error: ‘err_hw_init’ undeclared (first use in this function)
drivers/net/ieee802154/mrf24j40.c:741:10: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ieee802154/mrf24j40.c:759:1: warning: label ‘err_hw_init’ defined but not used [-Wunused-label]
drivers/net/ieee802154/mrf24j40.c:702:5: warning: unused variable ‘val’ [-Wunused-variable]
make[1]: *** [drivers/net/ieee802154/mrf24j40.o] Error 1
make: *** [drivers/net/ieee802154/mrf24j40.o] Error 2