lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 13 Jun 2014 09:06:52 +0530
From:	Varka Bhadram <>
To:	David Miller <>
	Alexander Smirnov <>,
	Dmitry Eremin-Solenikov <>,,, Varka Bhadram <>
Subject: Re: [PATCH net-next] mrf24j40: separate h/w init and add checkings

Hi David,

Sorry for the noise. i will send the fixed patch.


-Varka Bhadram

On Thu, Jun 12, 2014 at 11:35 PM, David Miller <> wrote:
> From: David Miller <>
> Date: Thu, 12 Jun 2014 11:03:24 -0700 (PDT)
>> From: Varka Bhadram <>
>> Date: Thu, 12 Jun 2014 14:40:48 +0530
>>> separate the mrf24j40 hardware initialisation from probe()
>>> and adds the sanity checkings.
>>> These checkings are required if somebody hasn't a right spi configuration
>>> the probe function should fail. So we have to return from there.
>>> Signed-off-by: Varka Bhadram <>
>> Applied, thanks.
> Reverted, did you even compile test this change?
> drivers/net/ieee802154/mrf24j40.c: In function ‘mrf24j40_probe’:
> drivers/net/ieee802154/mrf24j40.c:741:10: error: ‘err_hw_init’ undeclared (first use in this function)
> drivers/net/ieee802154/mrf24j40.c:741:10: note: each undeclared identifier is reported only once for each function it appears in
> drivers/net/ieee802154/mrf24j40.c:759:1: warning: label ‘err_hw_init’ defined but not used [-Wunused-label]
> drivers/net/ieee802154/mrf24j40.c:702:5: warning: unused variable ‘val’ [-Wunused-variable]
> make[1]: *** [drivers/net/ieee802154/mrf24j40.o] Error 1
> make: *** [drivers/net/ieee802154/mrf24j40.o] Error 2
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists