netdev - Re: [Xen-devel] [PATCH 1/2] xen-netfront: fix oops when disconnected from backend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618142300.GD20819@zion.uk.xensource.com>
Date:	Wed, 18 Jun 2014 15:23:01 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	<netdev@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	<wei.liu2@...rix.com>
Subject: Re: [Xen-devel] [PATCH 1/2] xen-netfront: fix oops when disconnected
 from backend

On Wed, Jun 18, 2014 at 10:47:27AM +0100, David Vrabel wrote:
> xennet_disconnect_backend() was not correctly iterating over all the
> queues.
> 
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>

Reviewed-by: Wei Liu <wei.liu2@...rix.com>

> ---
>  drivers/net/xen-netfront.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 5a7872a..daaf1e5 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -1287,7 +1287,7 @@ static irqreturn_t xennet_rx_interrupt(int irq, void *dev_id)
>  
>  	if (likely(netif_carrier_ok(dev) &&
>  		   RING_HAS_UNCONSUMED_RESPONSES(&queue->rx)))
> -			napi_schedule(&queue->napi);
> +		napi_schedule(&queue->napi);
>  

This indentation fix is not actually related to this bug. IMHO it should
either be removed or noted in commit message.

Wei.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html