netdev - Re: [Xen-devel] [PATCH 2/2] xen-netfront: recreate queues correctly when reconnecting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140618142509.GE20819@zion.uk.xensource.com>
Date:	Wed, 18 Jun 2014 15:25:09 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	David Vrabel <david.vrabel@...rix.com>
CC:	<netdev@...r.kernel.org>, <xen-devel@...ts.xenproject.org>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	<wei.liu2@...rix.com>
Subject: Re: [Xen-devel] [PATCH 2/2] xen-netfront: recreate queues correctly
 when reconnecting

On Wed, Jun 18, 2014 at 10:47:28AM +0100, David Vrabel wrote:
> When reconnecting to the backend (after a resume/migration, for example),
> a different number of queues may be required (since the guest may have
> moved to a different host with different capabilities).  During the
> reconnection the old queues are torn down and new ones created.
> 
> Introduce xennet_create_queues() and xennet_destroy_queues() that fixes
> three bugs during the reconnection.
> 
> - The old info->queues was leaked.
> - The old queue's napi instances were not deleted.
> - The new queue's napi instances were left disabled (which meant no
>   packets could be received).
> 
> The xennet_destroy_queues() calls is deferred until the reconnection
> instead of the disconnection (in xennet_disconnect_backend()) because
> napi_disable() might sleep.
> 
> Signed-off-by: David Vrabel <david.vrabel@...rix.com>

Reviewed-by: Wei Liu <wei.liu2@...rix.com>

> ---
>  drivers/net/xen-netfront.c |  104 ++++++++++++++++++++++++++++++--------------
>  1 file changed, 72 insertions(+), 32 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html