netdev - Re: [PATCH net-next 2/5] cxgb4 : Add DCBx support codebase and dcbnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140619.211546.719163351289410442.davem@davemloft.net>
Date:	Thu, 19 Jun 2014 21:15:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	anish@...lsio.com
Cc:	netdev@...r.kernel.org, leedom@...lsio.com, hariprasad@...lsio.com
Subject: Re: [PATCH net-next 2/5] cxgb4 : Add DCBx support codebase and
 dcbnl_ops

From: Anish Bhatt <anish@...lsio.com>
Date: Thu, 19 Jun 2014 15:22:08 -0700

> +#ifdef CONFIG_CHELSIO_T4_DCB
> +	struct port_dcb_info dcb;     /* Data Center Bridging support */
> +#endif

Don't reference data structure which do not exist until patches
later in your series.  Add those definitions first.

Your submission is impossible to review, and in fact presents itself
illogically, when you introduce infrastructure after it's uses.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html