netdev - Re: [PATCH V3 net-next] LISP: Locator/Identifier Separation Protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140619.211111.2189727364823929442.davem@davemloft.net>
Date:	Thu, 19 Jun 2014 21:11:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	chris@...icalelegance.com
Cc:	netdev@...r.kernel.org, vermagan@...co.com, lojakab@...co.com
Subject: Re: [PATCH V3 net-next] LISP: Locator/Identifier Separation
 Protocol

From: Christopher White <chris@...icalelegance.com>
Date: Thu, 19 Jun 2014 15:05:53 -0700

> +static inline struct rtable *ip_route_output_mark(struct net *net,
> +					__be32 *saddr, __be32 daddr,
> +					u8 ipproto, u8 tos, u32 skb_mark)
 ...
> +static inline  __be16 udp_tunnel_get_src_port(__u16 port_min, __u16 port_max,
> +					      struct sk_buff *skb)

These are not indented properly.

When a declaration, definition, or invocation of a function spans
multiple lines, the arguments on the second and subsequent lines
must begin at the first column after the openning parenthesis on
the first line.

You must use the appropriate number of TAB and SPACE characters
necessary to achieve this.  If you are indenting purely with
TAB characters, you are doing it wrong.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html