netdev - Re: [Patch net-next] veth: add netpoll support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53A48C12.8020104@cogentembedded.com>
Date:	Fri, 20 Jun 2014 23:31:30 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
CC:	s.priebe@...fihost.ag, "David S. Miller" <davem@...emloft.net>,
	Neil Horman <nhorman@...driver.com>
Subject: Re: [Patch net-next] veth: add netpoll support

Hello.

On 06/20/2014 11:17 PM, Cong Wang wrote:

> It is trivial to add netpoll support to veth, since
> it is not stacked device, we don't need to setup and cleanup
> netpoll.

> Reported-by: Stefan Priebe <s.priebe@...fihost.ag>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Neil Horman <nhorman@...driver.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

> ---
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index b4a10bc..03e781b 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
> @@ -248,6 +248,13 @@ static void veth_dev_free(struct net_device *dev)
>   	free_netdev(dev);
>   }
>
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +static void veth_poll_controller(struct net_device *dev)
> +{
> +	return;

    Not needed.

> +}
> +#endif	/* CONFIG_NET_POLL_CONTROLLER */
> +
>   static const struct net_device_ops veth_netdev_ops = {
>   	.ndo_init            = veth_dev_init,
>   	.ndo_open            = veth_open,

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html