netdev - Re: [PATCH net-next 1/2] procfs: split proc_pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140619.212254.967469891126477499.davem@davemloft.net>
Date:	Thu, 19 Jun 2014 21:22:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	p.wilczek@...sung.com
Cc:	netdev@...r.kernel.org, kyungmin.park@...sung.com,
	juho80.son@...sung.com, b.zolnierkie@...sung.com
Subject: Re: [PATCH net-next 1/2] procfs: split proc_pid_status function

From: Piotr Wilczek <p.wilczek@...sung.com>
Date: Tue, 17 Jun 2014 15:24:37 +0200

> +int proc_pid_status_mm(struct seq_file *m, struct pid_namespace *ns,
> +		       struct pid *pid, struct task_struct *task,
> +		       struct mm_struct *mm)
>  {
> -	struct mm_struct *mm = get_task_mm(task);
> -
>  	task_name(m, task);
>  	task_state(m, ns, pid, task);
>  
> -	if (mm) {
> +	if (mm)
>  		task_mem(m, mm);
> -		mmput(mm);

Neither proc_pid_status() nor the invocations in your second patch ever
invoke this function with a NULL mm, therefore you should never try to
explicitly handle the case.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html