netdev - Re: [PATCH net-next 2/2] Send process status in SCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140619.212518.877673821198961194.davem@davemloft.net>
Date:	Thu, 19 Jun 2014 21:25:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	p.wilczek@...sung.com
Cc:	netdev@...r.kernel.org, kyungmin.park@...sung.com,
	juho80.son@...sung.com, b.zolnierkie@...sung.com,
	jkaluza@...hat.com
Subject: Re: [PATCH net-next 2/2] Send process status in SCM_PROCINFO

From: Piotr Wilczek <p.wilczek@...sung.com>
Date: Tue, 17 Jun 2014 15:24:38 +0200

> diff --git a/net/core/scm.c b/net/core/scm.c
> index b442e7e..57a18f7 100644
> --- a/net/core/scm.c
> +++ b/net/core/scm.c
 ...
> @@ -38,6 +41,12 @@
>  #include <net/scm.h>
>  #include <net/cls_cgroup.h>
>  
> +extern int proc_pid_status_mm(struct seq_file *, struct pid_namespace *,
> +			      struct pid *, struct task_struct *,
> +			      struct mm_struct *mm);

Nope, this is not where you should declare this new public function.

You should declare it instead in the appropriate procfs header file
under include/linux

Also, you should do so in your first patch, not this one.

I also want you to provide a header "[PATCH 0/2] ..." posting with
this patch series explaining in extreme detail why you need this
feature, what will use it, and why existing facilities can't be
used.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html