netdev - Re: [PATCH] udp: Add MIB counters for rcvbuferrors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140621.150707.1970046713503112179.davem@davemloft.net>
Date:	Sat, 21 Jun 2014 15:07:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	james.leddy@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] udp: Add MIB counters for rcvbuferrors

From: James M Leddy <james.leddy@...hat.com>
Date: Tue, 17 Jun 2014 16:13:02 -0400

> Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
> 
> Signed-off-by: James M Leddy <james.leddy@...hat.com>

Please compile test your patches:

net/ipv4/udp.c: In function ‘udp_queue_rcv_skb’:
net/ipv4/udp.c:1538:5: error: label ‘csum_error’ used but not defined
make[1]: *** [net/ipv4/udp.o] Error 1
make: *** [net/ipv4/udp.o] Error 2

The encapsulation handling above your changes still use that label.

Besides, I see no reason to replace the goto csum_error; with
doing the counter bump by hand and jumping to "drop".  Especially
since, as per above, there is another code path which can make
use of and thus share that csum_error label code.