lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Jun 2014 15:12:58 -0700 (PDT) From: David Miller <davem@...emloft.net> To: roy.qing.li@...il.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH] 8021q: fix a potential memory leak From: roy.qing.li@...il.com Date: Wed, 18 Jun 2014 13:46:02 +0800 > From: Li RongQing <roy.qing.li@...il.com> > > skb_cow called in vlan_reorder_header does not free the skb when it failed, > and vlan_reorder_header returns NULL to reset original skb when it is called > in vlan_untag, lead to a memory leak. > > Signed-off-by: Li RongQing <roy.qing.li@...il.com> Applied and queued up for -stable, thanks. And I agree with Eric that we could define this to return error codes since 'skb' never changes so returning skb vs. NULL is rather awkward. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists