netdev - Re: [PATCH net-next v2 8/8] enic: do tx cleanup in napi poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140621.152440.2152576710542860161.davem@davemloft.net>
Date:	Sat, 21 Jun 2014 15:24:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	_govind@....com
Cc:	netdev@...r.kernel.org, ssujith@...co.com, benve@...co.com
Subject: Re: [PATCH net-next v2 8/8] enic: do tx cleanup in napi poll

From: Govindarajulu Varadarajan <_govind@....com>
Date: Wed, 18 Jun 2014 13:08:08 +0530

> Till now enic had been doing tx clean in isr.
> 
> Using napi infrastructure to move the tx clean up out of isr to softirq.
> Now, wq isr schedules napi poll. In enic_poll_msix_wq we clean up the tx queus.
> 
> This is applicable only on MSIX. In INTx and MSI we use single napi to clean
> both rx & tx queues.
> 
> Signed-off-by: Govindarajulu Varadarajan <_govind@....com>

It is recommended that TX work not count against the quota.

The cost of TX packet liberation is a minute percentage of what it
costs to process an RX frame.  Furthermore, that SKB freeing makes
memory available for other paths in the stack.

So please, just unconditionally purge the entire set of pending TX
queue completion entries without regards to the passed in NAPI quota
value at all.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html