netdev - Re: [PATCH net-next v2 8/8] enic: do tx cleanup in napi poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.03.1406221250230.1311@ws.cisco>
Date:	Sun, 22 Jun 2014 12:55:30 +0530 (IST)
From:	Govindarajulu Varadarajan <_govind@....com>
To:	David Miller <davem@...emloft.net>
cc:	_govind@....com, netdev@...r.kernel.org, ssujith@...co.com,
	benve@...co.com
Subject: Re: [PATCH net-next v2 8/8] enic: do tx cleanup in napi poll



On Sat, 21 Jun 2014, David Miller wrote:
> It is recommended that TX work not count against the quota.
>
> The cost of TX packet liberation is a minute percentage of what it
> costs to process an RX frame.  Furthermore, that SKB freeing makes
> memory available for other paths in the stack.
>
> So please, just unconditionally purge the entire set of pending TX
> queue completion entries without regards to the passed in NAPI quota
> value at all.
>

So I should ignore the budget value and clean all packets possible. And what
should the NAPIs return value should be? I can not be > 64 right?

Or should I netif_napi_add() with highest value possible? For enic its 4096.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html