lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Jun 2014 18:27:34 +0200 From: Oliver Hartkopp <socketcan@...tkopp.net> To: David Miller <davem@...emloft.net>, duanj.fnst@...fujitsu.com, lisovy@...il.com CC: netdev@...r.kernel.org Subject: Re: [PATCH net-next] net: em_canid: remove useless statements from em_canid_change This is right for the first set of filters that is ever configured in em_canid_change(). But what happens in an update case? Does is turn the cm_old reference to a memory leak then? Or do we always get a brand new "struct tcf_ematch *m" here?? Regards, Oliver On 22.06.2014 00:40, David Miller wrote: > From: Duan Jiong <duanj.fnst@...fujitsu.com> > Date: Wed, 18 Jun 2014 16:48:39 +0800 > >> tcf_ematch is allocated by kzalloc in function tcf_em_tree_validate(), >> so cm_old is always NULL. >> >> Signed-off-by: Duan Jiong <duanj.fnst@...fujitsu.com> > > Applied, thanks. > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists