netdev - Re: [PATCH net-next] net: em_canid: remove useless statements from em_canid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140622.172707.816044847520857805.davem@davemloft.net>
Date:	Sun, 22 Jun 2014 17:27:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	socketcan@...tkopp.net
Cc:	duanj.fnst@...fujitsu.com, lisovy@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: em_canid: remove useless statements from
 em_canid_change

From: Oliver Hartkopp <socketcan@...tkopp.net>
Date: Sun, 22 Jun 2014 18:27:34 +0200

> This is right for the first set of filters that is ever configured in
> em_canid_change().
> 
> But what happens in an update case?
> Does is turn the cm_old reference to a memory leak then?
> 
> Or do we always get a brand new "struct tcf_ematch *m" here??

There is only one call to this method is tcf_em_validate(), which also
unconditionally assigns new pointers to em->data without checking if
an existing non-NULL value is in em->data.  Specifically in the code
path where em->ops->change is not implemented.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html