netdev - Re: Stable request for 5882a07c72093d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 15:37:18 -0700
From:	Wei-Chun Chao <weichunc@...mgrid.com>
To:	chiluk@...onical.com
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	netdev <netdev@...r.kernel.org>, davem <davem@...emloft.net>
Subject: Re: Stable request for 5882a07c72093d

On Mon, Jun 23, 2014 at 10:35 AM, Dave Chiluk <chiluk@...onical.com> wrote:
> On 06/23/2014 11:18 AM, Eric Dumazet wrote:
>> On Mon, 2014-06-23 at 10:56 -0500, Dave Chiluk wrote:
>>> Commit 5882a07c72093dc3a18e2d2b129fb200686bb6ee remedies a BUG_ON in
>>> skb_segment.  This is hit reliably in clouds that are using openvswitch for
>>> network capabilities (which is the default network used by Openstack) on
>>> machines that have gso offload capabilities.
>>>
>>> This has already been reported multiple times to Canonical in numerous
>>> openstack clouds.  The fix has been integrated and tested in those clouds, and
>>> has been show to resolve their issues.
>>>
>>> Please include this patch for stable release.
>>>
>>> Thank you,
>>> Dave Chiluk
>>>
>>> The patch follows for convenience.
>>> --
>>
>> Both original commit and your request lack the bug origin.
>>
>> I wish bug submissions are more explicit in this regard, using
>>
>> Fixes: sha1-12digits ("title")
>>
>> It would save a lot of time for stable teams, and ease future bug
>> hunting as well.
>>
>>
> According to the initial thread, Wei-Chun determined it originated with
> 19acc327258a.  It has existed since 3.10-rc1.
>
> Fixes: 19acc327258a ("gso: Handle Trans-Ether-Bridging protocol in
> skb_network_protocol()")
>

Sorry I didn't include the bug origin in the original patch.

The issue was introduced by the combination of these two commits -
ec5f06156423 ("net: Kill link between CSUM and SG features.)
19acc327258a ("gso: Handle Trans-Ether-Bridging protocol in
skb_network_protocol()")

Thanks,
Weichun
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html