| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1403563331.12008.5.camel@Lunix2.home> Date: Mon, 23 Jun 2014 15:42:11 -0700 From: Don Fry <pcnet32@...ntier.com> To: Joe Perches <joe@...ches.com> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] amd: Neaten and remove unnecessary OOM messages On Mon, 2014-06-23 at 14:36 -0700, Joe Perches wrote: > Make the code flow a little better for 80 columns. > > Use a consistent style for the RX and TX rings allocation. > Use BIT macro. > Use a temporary unsiged int entries for (1<<size). > Remove the OOM messages as they duplicate the generic > OOM and dump_stack() provided by the memory subsystem. > Reflow allocs to 80 columns. > > Signed-off-by: Joe Perches <joe@...ches.com> > --- > drivers/net/ethernet/amd/pcnet32.c | 43 ++++++++++++++++---------------------- > 1 file changed, 18 insertions(+), 25 deletions(-) > > diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c > index 8099fdc..4a8fdc4 100644 > --- a/drivers/net/ethernet/amd/pcnet32.c > +++ b/drivers/net/ethernet/amd/pcnet32.c > @@ -481,36 +481,32 @@ static void pcnet32_realloc_tx_ring(struct net_device *dev, > dma_addr_t *new_dma_addr_list; Acked-By: Don Fry <pcnet32@...ntier.com> > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists