netdev - RE: [PATCH net-next] sctp: Add partially support for MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1726152D@AcuExch.aculab.com>
Date:	Mon, 23 Jun 2014 14:27:49 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'Vlad Yasevich' <vyasevich@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>
Subject: RE: [PATCH net-next] sctp: Add partially support for MSG_MORE to
 SCTP.

From: Vlad Yasevich
> On 06/20/2014 12:24 PM, David Laight wrote:
> > If MSG_MORE is set then buffer sends as if Nagle were enabled.
> > The first data chunk is still sent on its own, but subsequent chunks
> > will be bundled and full packets sent.
> > Full MSG_MORE support would require a timeout (preferably configurable
> > per-socket) to send the last chunk(s), instead of sending them
> > when there is nothing outstanding.
> >
> 
> Instead of using 1 and 2, can you define them as flags please

Will do....

It is worth inverting nagle/nodelay bit; so that:
0 => SCTP_NODELAY
1 => Nagle (default)
2 => MSG_MORE
4 => reserved for corked

That would require working out where the structure is initialised
(in order to default to Nagle).

	David



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html