netdev - Re: [PATCH net-next] sctp: Add partially support for MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53AAA44C.5010206@redhat.com>
Date:	Wed, 25 Jun 2014 12:28:28 +0200
From:	Daniel Borkmann <dborkman@...hat.com>
To:	David Laight <David.Laight@...LAB.COM>
CC:	"'Vlad Yasevich'" <vyasevich@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-sctp@...r.kernel.org" <linux-sctp@...r.kernel.org>
Subject: Re: [PATCH net-next] sctp: Add partially support for MSG_MORE to
 SCTP.

On 06/23/2014 04:27 PM, David Laight wrote:
> From: Vlad Yasevich
>> On 06/20/2014 12:24 PM, David Laight wrote:
>>> If MSG_MORE is set then buffer sends as if Nagle were enabled.
>>> The first data chunk is still sent on its own, but subsequent chunks
>>> will be bundled and full packets sent.
>>> Full MSG_MORE support would require a timeout (preferably configurable
>>> per-socket) to send the last chunk(s), instead of sending them
>>> when there is nothing outstanding.
>>
>> Instead of using 1 and 2, can you define them as flags please
>
> Will do....
>
> It is worth inverting nagle/nodelay bit; so that:
> 0 => SCTP_NODELAY
> 1 => Nagle (default)
> 2 => MSG_MORE
> 4 => reserved for corked
>
> That would require working out where the structure is initialised
> (in order to default to Nagle).

I think that should be fine, too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html