netdev - Re: [net-next v2 03/13] net: remove inet6_reqsk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE1zotKQDf5tks+_tnnP_40wOhu2faXL5b7dgX8p3suP4V8d_Q@mail.gmail.com>
Date:	Wed, 25 Jun 2014 21:04:07 +0300
From:	Octavian Purdila <octavian.purdila@...el.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [net-next v2 03/13] net: remove inet6_reqsk_alloc

On Wed, Jun 25, 2014 at 8:59 PM, Cong Wang <cwang@...pensource.com> wrote:
> On Wed, Jun 25, 2014 at 7:09 AM, Octavian Purdila
> <octavian.purdila@...el.com> wrote:
>> Since pktops is only used for IPv6 only and opts is used for IPv4
>> only, we can move these fields into a union and this allows us to drop
>> the inet6_reqsk_alloc function as after this change it becomes
>> equivalent with inet_reqsk_alloc.
>>
>
> Or use kmem_cache_zalloc() so that inet_reqsk_alloc() doesn't have
> to init ->opt to NULL explicitly.

Wouldn't that be costly?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html