netdev - Re: [PATCH] tcp: fix setting csum_start in tcp_gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140625.115258.1446490446271879078.davem@davemloft.net>
Date:	Wed, 25 Jun 2014 11:52:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	davej@...hat.com
Cc:	torvalds@...ux-foundation.org, therbert@...gle.com,
	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tcp: fix setting csum_start in tcp_gso_segment

From: Dave Jones <davej@...hat.com>
Date: Wed, 25 Jun 2014 10:10:52 -0400

> On Tue, Jun 24, 2014 at 09:17:25PM -0700, Linus Torvalds wrote:
>  > On Tue, Jun 24, 2014 at 9:03 PM, Tom Herbert <therbert@...gle.com> wrote:
>  > >
>  > > It looks like a likely culprit is that SKB_GSO_CB()->csum_start is
>  > > not set correctly when doing non-scatter gather. We are using
>  > > offset as opposed to doffset.
>  > >
>  > > Reported-by: Dave Jones <davej@...hat.com>
>  > 
>  > DaveJ, I think you triggered this in five minutes on your box, and I
>  > don't recall seeing anybody else reporting the oops (and google
>  > doesn't find anything in the last month). So it's presumably somewhat
>  > hw-specific. Does this fix the problem?
> 
> It's survived routing ~1GB of packets overnight, so I'd call this good.

Tom, please adjust the Subject line as suggested by Eric Dumazet and add
a Tested-by: for Dave.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html