netdev - Re: [PATCH 05/17] MIPS: bpf: Return error code if the offset is a negative number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53AA8485.4040805@imgtec.com>
Date:	Wed, 25 Jun 2014 09:12:53 +0100
From:	Markos Chandras <Markos.Chandras@...tec.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
CC:	Linux MIPS Mailing List <linux-mips@...ux-mips.org>,
	"David S. Miller" <davem@...emloft.net>,
	Daniel Borkmann <dborkman@...hat.com>,
	"Network Development" <netdev@...r.kernel.org>
Subject: Re: [PATCH 05/17] MIPS: bpf: Return error code if the offset is a
 negative number

On 06/23/2014 11:09 PM, Alexei Starovoitov wrote:
> On Mon, Jun 23, 2014 at 2:38 AM, Markos Chandras
> <markos.chandras@...tec.com> wrote:
>> Previously, the negative offset was not checked leading to failures
>> due to trying to load data beyond the skb struct boundaries. Until we
>> have proper asm helpers in place, it's best if we return ENOSUPP if K
>> is negative when trying to JIT the filter or 0 during runtime if we
>> do an indirect load where the value of X is unknown during build time.
>>
>> Cc: "David S. Miller" <davem@...emloft.net>
>> Cc: Daniel Borkmann <dborkman@...hat.com>
>> Cc: Alexei Starovoitov <ast@...mgrid.com>
>> Cc: netdev@...r.kernel.org
>> Signed-off-by: Markos Chandras <markos.chandras@...tec.com>
> 
> Hi Markos,
> 
> thank you for addressing all of my earlier comments.
> Looks like test_bpf was quite useful in finding all of these bugs :)
> For the patches that reached netdev:
> 
> Acked-by: Alexei Starovoitov <ast@...mgrid.com>
> 

Thank you for the review and your constructive comments in your previous
emails.

-- 
markos
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html