netdev - Re: [PATCH net-next 1/3] ptp: Allow reassigning calibration pin function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140626052144.GB4537@netboy>
Date:	Thu, 26 Jun 2014 07:21:45 +0200
From:	Richard Cochran <richardcochran@...il.com>
To:	Stefan Sørensen 
	<stefan.sorensen@...ctralink.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] ptp: Allow reassigning calibration pin
 function

On Wed, Jun 25, 2014 at 02:37:29PM +0200, Stefan Sørensen wrote:
> The ptp pin function programming does not allow calibration pin to change
> function. This is problematic on hardware that uses the default calibration
> pin for other purposes.
> 
> Removing this limitation does not impact calibration if userspace does not
> reprogram the calibration pin.

Reassigning the calibration function never makes sense, because it is
only used in the driver probe method.

Clobbering the calibration pin with another function only makes sense
if the hardware design has exactly one PHY.

Can you please add a check in the dp83640 verify method to enforce
these two constraints?

Thanks,
Richard

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html