netdev - Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcaCesZ29U5xth+B0YNKv4yQ=JuFVV+QyJ7MmFJ7jKTPgg@mail.gmail.com>
Date:	Tue, 1 Jul 2014 21:38:53 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	netdev <netdev@...r.kernel.org>, Varka Bhadram <varkab@...c.in>,
	David Miller <davem@...emloft.net>,
	linux-zigbee-devel@...ts.sourceforge.net,
	Joe Perches <joe@...ches.com>
Subject: Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154: fix
 coding style issues

2014-07-01 21:28 GMT-07:00 Varka Bhadram <varkabhadram@...il.com>:
> Hi  Florian,
>
>
> On 07/02/2014 09:50 AM, Florian Fainelli wrote:
>>
>> Hi,
>>
>> 2014-07-01 20:31 GMT-07:00 Varka Bhadram <varkabhadram@...il.com>:
>>>
>>> This patch fixed the coding style issues reported by checkpatch.pl
>>>
>>> following issues fixed:
>>>          CHECK: Alignment should match open parenthesis
>>
>> It seems to me like checkpatch.pl should have a special case for
>> networking code and that specific condition because fixing things to
>> make checkpatch.pl happy seems not to agree with the general coding
>> style recommended and enforced in the networking code.
>>
>> I just saw that new warning added popping up on a bunch of drivers
>> that were properly fixed to match the networking coding style before
>> submission.
>
>
> Sorry, I didn't get what you are saying...
>
> Is there any thing to be fixed in the patch ?

I think the "CHECK: Alignment should match open parenthesis" lines
reported by checkpatch.pl should not be fixed, the current code seems
fine according to the network subsystem coding standards.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html