netdev - Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154: fix coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1404276016.14624.57.camel@joe-AO725>
Date:	Tue, 01 Jul 2014 21:40:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	Varka Bhadram <varkabhadram@...il.com>,
	netdev <netdev@...r.kernel.org>, Varka Bhadram <varkab@...c.in>,
	David Miller <davem@...emloft.net>,
	linux-zigbee-devel@...ts.sourceforge.net
Subject: Re: [Linux-zigbee-devel] [PATCH net-next v3] 6lowpan: mac802154:
 fix coding style issues

On Tue, 2014-07-01 at 21:20 -0700, Florian Fainelli wrote:
> Hi,
> 
> 2014-07-01 20:31 GMT-07:00 Varka Bhadram <varkabhadram@...il.com>:
> > This patch fixed the coding style issues reported by checkpatch.pl
> >
> > following issues fixed:
> >         CHECK: Alignment should match open parenthesis
> 
> It seems to me like checkpatch.pl should have a special case for
> networking code and that specific condition because fixing things to
> make checkpatch.pl happy seems not to agree with the general coding
> style recommended and enforced in the networking code.

In networking (net/ and drivers/net) alignment of multiline statements
_should_ align to the open parenthesis and checkpatch already has a
specific check for those directories.

> I just saw that new warning added popping up on a bunch of drivers
> that were properly fixed to match the networking coding style before
> submission.

Is there anything you want changed in checkpatch?
If so, why?

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html