[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20140708.152057.490185410038470309.davem@davemloft.net>
Date: Tue, 08 Jul 2014 15:20:57 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: khoroshilov@...ras.ru
Cc: kevin.curtis@...site.co.uk, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] farsync: fix invalid memory accesses in fst_add_one()
and fst_init_card()
From: Alexey Khoroshilov <khoroshilov@...ras.ru>
Date: Sat, 5 Jul 2014 03:35:50 +0400
> - }
> + card->nports = i;
> + return (card->nports == 0) ? err : 0;
> + }
I don't think this is the right thing to do.
This will cause the caller to not free the IRQ or any of the
other resources.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists