netdev - Re: [PATCH v2 1/3] ethernet: Add new driver for Marvell Armada 375 network unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140708.152655.619472955292197550.davem@davemloft.net>
Date:	Tue, 08 Jul 2014 15:26:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ezequiel.garcia@...e-electrons.com
Cc:	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	jason@...edaemon.net, mw@...ihalf.com,
	thomas.petazzoni@...e-electrons.com,
	gregory.clement@...e-electrons.com, tawfik@...vell.com,
	alior@...vell.com
Subject: Re: [PATCH v2 1/3] ethernet: Add new driver for Marvell Armada 375
 network unit

From: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
Date: Sat,  5 Jul 2014 08:54:46 -0300

> +module_param(rxq_number, int, S_IRUGO);
> +module_param(txq_number, int, S_IRUGO);

Please don't use module parameters (undocumented ones at that) for things
like this.

Instead, use or create standard interfaces which other drivers can use as
well, so that the user interface is consistent for setting things of this
nature regardless of device type.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html