netdev - Re: [PATCH v2 1/3] ethernet: Add new driver for Marvell Armada 375 network unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140708234024.GA28830@arch.cereza>
Date:	Tue, 8 Jul 2014 20:40:24 -0300
From:	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
To:	David Miller <davem@...emloft.net>
Cc:	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	jason@...edaemon.net, mw@...ihalf.com,
	thomas.petazzoni@...e-electrons.com,
	gregory.clement@...e-electrons.com, tawfik@...vell.com,
	alior@...vell.com
Subject: Re: [PATCH v2 1/3] ethernet: Add new driver for Marvell Armada 375
 network unit

On 08 Jul 03:26 PM, David Miller wrote:
> From: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
> Date: Sat,  5 Jul 2014 08:54:46 -0300
> 
> > +module_param(rxq_number, int, S_IRUGO);
> > +module_param(txq_number, int, S_IRUGO);
> 
> Please don't use module parameters (undocumented ones at that) for things
> like this.
> 
> Instead, use or create standard interfaces which other drivers can use as
> well, so that the user interface is consistent for setting things of this
> nature regardless of device type.
> 

Hm... in fact these two parameters should be removed. They are redundant in
this and the mvneta driver. The Rx queue number should be fixed and none of
the drivers support more than 1.

The Tx queue number should be set to the hardware supported one, there's no
reason to use something different.

So, unless someone objects, we'll remove them in v4.

Thanks for the feedback,
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html