netdev - Re: [PATCH net] net/mlx4_en: Don't configure the HW vxlan parser when vxlan offloading isn't set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140707.214008.1100817705691828133.davem@davemloft.net>
Date:	Mon, 07 Jul 2014 21:40:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, amirv@...lanox.com
Subject: Re: [PATCH net] net/mlx4_en: Don't configure the HW vxlan parser
 when vxlan offloading isn't set

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Wed,  2 Jul 2014 17:36:23 +0300

> The add_vxlan_port ndo driver code was wrongly testing whether HW vxlan offloads
> are supported by the device instead of checking if they are currently enabled.
> 
> This causes the driver to configure the HW parser to conduct matching for vxlan
> packets but since no steering rules were set, vxlan packets are dropped on RX.
> 
> Fix that by doing the right test, as done in the del_vxlan_port ndo handler.
> 
> Fixes: 1b136de ('net/mlx4: Implement vxlan ndo calls')
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
> ---
> 
> Hi Dave,
> 
> This fixes a bug from 3.15-rc1, can you please push to 3.15.y too?

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html