netdev - Re: [PATCH net] tcp: fix false undo corner cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140707.214117.2003241916862387142.davem@davemloft.net>
Date:	Mon, 07 Jul 2014 21:41:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ycheng@...gle.com
Cc:	ncardwell@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: fix false undo corner cases

From: Yuchung Cheng <ycheng@...gle.com>
Date: Wed,  2 Jul 2014 12:07:16 -0700

> The undo code assumes that, upon entering loss recovery, TCP
> 1) always retransmit something
> 2) the retransmission never fails locally (e.g., qdisc drop)
> 
> so undo_marker is set in tcp_enter_recovery() and undo_retrans is
> incremented only when tcp_retransmit_skb() is successful.
> 
> When the assumption is broken because TCP's cwnd is too small to
> retransmit or the retransmit fails locally. The next (DUP)ACK
> would incorrectly revert the cwnd and the congestion state in
> tcp_try_undo_dsack() or tcp_may_undo(). Subsequent (DUP)ACKs
> may enter the recovery state. The sender repeatedly enter and
> (incorrectly) exit recovery states if the retransmits continue to
> fail locally while receiving (DUP)ACKs.
> 
> The fix is to initialize undo_retrans to -1 and start counting on
> the first retransmission. Always increment undo_retrans even if the
> retransmissions fail locally because they couldn't cause DSACKs to
> undo the cwnd reduction.
> 
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>

Applied, thanks.

Do you guys think this is -stable material?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html