lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 08 Jul 2014 20:56:05 -0700 (PDT) From: David Miller <davem@...emloft.net> To: varkabhadram@...il.com Cc: netdev@...r.kernel.org, alex.aring@...il.com, linux-zigbee-devel@...ts.sourceforge.net, varkab@...c.in Subject: Re: [PATCH net-next 1/2] ieee802154: removed unwanted header files From: Varka Bhadram <varkabhadram@...il.com> Date: Wed, 9 Jul 2014 09:14:04 +0530 > diff --git a/net/ieee802154/6lowpan_iphc.c b/net/ieee802154/6lowpan_iphc.c > index 511ddee..d85caa2 100644 > --- a/net/ieee802154/6lowpan_iphc.c > +++ b/net/ieee802154/6lowpan_iphc.c > @@ -49,12 +49,8 @@ > * SUCH DAMAGE. > */ > > -#include <linux/bitops.h> > -#include <linux/if_arp.h> > #include <linux/module.h> > -#include <linux/netdevice.h> > #include <net/6lowpan.h> > -#include <net/ipv6.h> > #include <net/af_ieee802154.h> > These changes are completely bogus. Where are the definitions of the data types for "struct in6_addr" and "struct ipv6hdr" coming from. I'm not even going to look at these patches until you: 1) Properly audit the files. Removing an include and typing "make" is not auditing the header file requriements. Reading the code and looking at where declarations and definitions actually come from _is_. 2) Write a real commit message, this one is way too terse and tells me nothing. Explain why each header file was removed, and what the justification is. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists