netdev - Re: [PATCH net-next 1/2] ieee802154: removed unwanted header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53BCC49C.5090503@gmail.com>
Date:	Wed, 09 Jul 2014 09:57:08 +0530
From:	Varka Bhadram <varkabhadram@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, alex.aring@...il.com,
	linux-zigbee-devel@...ts.sourceforge.net, varkab@...c.in
Subject: Re: [PATCH net-next 1/2] ieee802154: removed unwanted header files

On 07/09/2014 09:26 AM, David Miller wrote:
> These changes are completely bogus.
>
> Where are the definitions of the data types for "struct in6_addr" and
> "struct ipv6hdr" coming from.
>
> I'm not even going to look at these patches until you:
>
> 1) Properly audit the files.  Removing an include and typing "make"
>     is not auditing the header file requriements.  Reading the code
>     and looking at where declarations and definitions actually come
>     from _is_.

I got your point. Thanks

>
> 2) Write a real commit message, this one is way too terse and tells me
>     nothing.  Explain why each header file was removed, and what the
>     justification is.

Ok i will explain about the changes. I thinks i have to change the entire
patch. I have to rework on it. Thanks


-- 
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html