| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1405616296.12363.45.camel@joe-AO725> Date: Thu, 17 Jul 2014 09:58:16 -0700 From: Joe Perches <joe@...ches.com> To: Veaceslav Falico <vfalico@...il.com> Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Tom Gundersen <teg@...m.no> Subject: Re: [PATCH v2 net-next 1/2] net: use dev->name in netdev_pr* when it's available On Thu, 2014-07-17 at 18:38 +0200, Veaceslav Falico wrote: > On Thu, Jul 17, 2014 at 09:36:08AM -0700, Joe Perches wrote: > >On Thu, 2014-07-17 at 18:25 +0200, Veaceslav Falico wrote: > >> On Thu, Jul 17, 2014 at 09:18:44AM -0700, Joe Perches wrote: > >> >On Thu, 2014-07-17 at 16:09 +0200, Veaceslav Falico wrote: > >> >> netdev_name() returns dev->name only when the net_device is in > >> >> NETREG_REGISTERED state. > >[] > >> >Maybe this should not be inline and become something like: > >> > >> It will miss the states then, when it's not NETREG_REGISTERED. > > > >If it's registered, it has a valid name via > >dev_get_valid_name() doesn't it? > > Yes, I'm speaking about the NETREG_* states when it's not registered. > > i.e.: > > Jul 17 13:35:29 darkmag kernel: [ 602.686489] bond2 (unregistering): Released all slaves OK, I hadn't read the patch where netdev_reg_state was emitted. Still, it's probably smaller overall code to uninline it now. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists