netdev - Re: [GIT net-next v4] Open vSwitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140717.145756.1982098731634690697.davem@davemloft.net>
Date:	Thu, 17 Jul 2014 14:57:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pshelar@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [GIT net-next v4] Open vSwitch

From: David Miller <davem@...emloft.net>
Date: Thu, 17 Jul 2014 14:48:48 -0700 (PDT)

> From: Pravin B Shelar <pshelar@...ira.com>
> Date: Wed, 16 Jul 2014 17:17:43 -0700
> 
>> Following patches adds three features to OVS
>> 1. Add fairness to upcall processing.
>> 2. Recirculation and Hash action.
>> 3. Enable Tunnel GSO features.
>> Rest of patches are bug fixes related to patches from same series.
>> 
>> v2 series changes first patch according to comment from Dave Miller.
>> v3 series changes first patch according to comment from Nikolay Aleksandrov.
>> v4 series changes recirc patch commit msg.
> 
> Pulled, thanks.

Actually, reverted, this code doesn't even compile.

net/openvswitch/datapath.c: In function ‘ovs_dp_process_packet_with_key’:
net/openvswitch/datapath.c:271:43: error: ‘key’ undeclared (first use in this function)
net/openvswitch/datapath.c:271:43: note: each undeclared identifier is reported only once for each function it appears in

It would be a strong understatement to say that I'm disappointed at this.

Are you even build testing the tree you are asking me to pull from?  This
means you can't have possibly have functionally tested the code.