netdev - Re: [GIT net-next v4] Open vSwitch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2014 15:25:45 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [GIT net-next v4] Open vSwitch

On Thu, Jul 17, 2014 at 2:57 PM, David Miller <davem@...emloft.net> wrote:
> From: David Miller <davem@...emloft.net>
> Date: Thu, 17 Jul 2014 14:48:48 -0700 (PDT)
>
>> From: Pravin B Shelar <pshelar@...ira.com>
>> Date: Wed, 16 Jul 2014 17:17:43 -0700
>>
>>> Following patches adds three features to OVS
>>> 1. Add fairness to upcall processing.
>>> 2. Recirculation and Hash action.
>>> 3. Enable Tunnel GSO features.
>>> Rest of patches are bug fixes related to patches from same series.
>>>
>>> v2 series changes first patch according to comment from Dave Miller.
>>> v3 series changes first patch according to comment from Nikolay Aleksandrov.
>>> v4 series changes recirc patch commit msg.
>>
>> Pulled, thanks.
>
> Actually, reverted, this code doesn't even compile.
>
> net/openvswitch/datapath.c: In function ‘ovs_dp_process_packet_with_key’:
> net/openvswitch/datapath.c:271:43: error: ‘key’ undeclared (first use in this function)
> net/openvswitch/datapath.c:271:43: note: each undeclared identifier is reported only once for each function it appears in
>
> It would be a strong understatement to say that I'm disappointed at this.
>
> Are you even build testing the tree you are asking me to pull from?  This
> means you can't have possibly have functionally tested the code.
>
Yesterday when I created my branch, net-next was not merged with net.
Now you have merged it. That resulted in conflict (due to commit
ad55200734c65a3ec5d0c39d6ea904008baea536) which was silently resolved
and as result you got error.

I did not refreshed my base net-next tree just before sending last
pull request Sorry about that.
I will update my branch to solve conflict send updated pull request.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html