netdev - Re: mvebu: Can we make the orion-mdio clock a requirement?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53CD743D.9080700@gmail.com>
Date:	Mon, 21 Jul 2014 22:12:45 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
CC:	netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Jason Cooper <jason@...edaemon.net>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Andrew Lunn <andrew@...n.ch>
Subject: Re: mvebu: Can we make the orion-mdio clock a requirement?

On 07/21/2014 09:28 PM, Thomas Petazzoni wrote:
> On Mon, 21 Jul 2014 16:06:15 -0300, Ezequiel Garcia wrote:
>> Currently the mvmdio driver does not require a clock to be declared,
>> and instead this is optional.
>>
>> However (almost) all the platforms that currently use it, i.e. the
>> Armada, Kirkwood and Dove SoCs, require some clock to be enabled before
>> the MDIO registers can be accessed.
>>
>> The Orion5x SoC doesn't declare any clock for neither the ethernet node,
>> nor the MDIO node. Is that correct?
> 
> There are no gatable clocks on Orion5x, so unless the driver really
> wants a clock, there's no hard requirement to give a clock reference.
> 
>> Do you think we could make the clock a required property in the mvmdio
>> devicetree node? How would that behave in the non-DT case?
> 
> I don't think the mvmdio driver is used in non-DT contexts.
> 
> However, yes, I tend to agree, making the clock mandatory would
> probably be a good thing.

We can always pass TCLK on Orion5x if there is a need for a mandatory
clock. Anyway, IIRC clock framework should now properly return
-EPROPEDEFER only if there is a clock property set. If there is none,
the error is different and can be catched on Orion5x.

Sebastian


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html