netdev - RE: FEC driver hangs hardware on i.MX6SX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06acadb1ae284d39915d32a7adfb052f@BLUPR03MB373.namprd03.prod.outlook.com>
Date:	Mon, 21 Jul 2014 02:13:39 +0000
From:	"fugang.duan@...escale.com" <fugang.duan@...escale.com>
To:	Shawn Guo <Shawn.Guo@...escale.com>,
	Richard Cochran <richardcochran@...il.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Frank.Li@...escale.com" <Frank.Li@...escale.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: RE: FEC driver hangs hardware on i.MX6SX

From: Shawn Guo <shawn.guo@...escale.com> Data: Monday, July 21, 2014 9:59 AM
>To: Richard Cochran
>Cc: Duan Fugang-B38611; linux-arm-kernel@...ts.infradead.org;
>netdev@...r.kernel.org; Li Frank-B20596; David S. Miller
>Subject: Re: FEC driver hangs hardware on i.MX6SX
>
>On Sun, Jul 20, 2014 at 08:20:49AM +0200, Richard Cochran wrote:
>> On Sun, Jul 20, 2014 at 10:57:33AM +0800, Shawn Guo wrote:
>> >
>> > I think the cause is that PTP is still accessing registers after FEC
>> > driver calls fec_enet_clk_enable(ndev, false) to disable FEC clocks.
>> > Can you please try to provide a fix for this regression soon?
>>
>> What do you mean by, "PTP is still accessing registers"?
>>
>> The only access to any register is through the driver, and the driver
>> can and should make sure all register accesses are safe.
>
>Sorry for being vague, Richard.  I meant PTP driver is still accessing
>registers.
>
>With Fugang's clock management patch, FEC clocks will be disabled to save
>power after FEC gets probed.  But at that point, fec_ptp driver already
>launches a timer, which will trigger the read on FEC ATIME register once
>per second.
>
>Shawn
	
Yes, why does it cause at imx6sx platform ?
Because imx5x, imx6q/dl/sl  enet register access don't cause system hang when clock is disab led, just return one error value that is zero.
But for imx6sx, if there disable enet ipg clock, and access register, which cause system hang.

For clock management patch itself, there have no any problem.  
Just ptp driver has one issue which think clock is always on.

I  submit one patch to fix the ptp issue.

Thanks,
Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html