netdev - Re: [PATCH -next] tipc: fix sparse non static symbol warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jul 2014 10:36:40 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	<weiyj_lk@....com>, Jon Maloy <jon.maloy@...csson.com>,
	Allan Stephens <allan.stephens@...driver.com>,
	"David S. Miller" <davem@...emloft.net>
CC:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	<netdev@...r.kernel.org>, <tipc-discussion@...ts.sourceforge.net>
Subject: Re: [PATCH -next] tipc: fix sparse non static symbol warnings

On 07/20/2014 01:14 PM, weiyj_lk@....com wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fixes the following sparse warnings:
> 
> net/tipc/socket.c:545:5: warning:
>  symbol 'tipc_sk_proto_rcv' was not declared. Should it be static?
> net/tipc/socket.c:2015:5: warning:
>  symbol 'tipc_ioctl' was not declared. Should it be static?
> 

Acked-by: Ying Xue <ying.xue@...driver.com>

> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  net/tipc/socket.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index de01622..42c3599 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -542,7 +542,8 @@ static unsigned int tipc_poll(struct file *file, struct socket *sock,
>   * Returns 0 (TIPC_OK) if message was consumed, 1 (TIPC_FWD_MSG) if
>   * (CONN_PROBE_REPLY) message should be forwarded.
>   */
> -int tipc_sk_proto_rcv(struct tipc_sock *tsk, u32 *dnode, struct sk_buff *buf)
> +static int tipc_sk_proto_rcv(struct tipc_sock *tsk, u32 *dnode,
> +			     struct sk_buff *buf)
>  {
>  	struct tipc_msg *msg = buf_msg(buf);
>  	struct tipc_port *port = &tsk->port;
> @@ -2012,7 +2013,7 @@ static int tipc_getsockopt(struct socket *sock, int lvl, int opt,
>  	return put_user(sizeof(value), ol);
>  }
>  
> -int tipc_ioctl(struct socket *sk, unsigned int cmd, unsigned long arg)
> +static int tipc_ioctl(struct socket *sk, unsigned int cmd, unsigned long arg)
>  {
>  	struct tipc_sioc_ln_req lnr;
>  	void __user *argp = (void __user *)arg;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html